On 9 Jun 2026, at 12:58, Paolo Abeni wrote:

On 6/4/26 6:30 PM, Minxi Hou wrote:

quoted

When ip-link output is unavailable, when the upcall daemon log has not
been written yet, or when pahole does not know the OVS drop subsystem
ID, the affected command substitutions silently produce empty strings.
The caller then passes empty sha= or pid= arguments to ovs_add_flow,
or matches against wrong drop reason codes, all without a diagnostic.

Add [ -z ] guards immediately after each assignment. For test_arp_ping,
also align the MAC extraction to use awk '/link\/ether/' as in
test_pop_vlan. The drop_reason guard returns ksft_skip because an
absent subsystem ID is an environment issue, not a test failure.

Signed-off-by: Minxi Hou <redacted>

Whoops, I unintentionally replied to an old revision; same point, I
think this is net-next material.

@ovs crew: WDYT?

+1 on net-next.