Re: [PATCH v3 1/3] dt-bindings: net: add Realtek r8169 family PCIe Ethernet
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-06-08 07:58:12
Also in:
linux-arm-kernel, linux-devicetree, linux-rockchip, lkml
On Fri, Jun 05, 2026 at 01:49:08PM +0200, Ricardo Pardini wrote:
quoted hunk ↗ jump to hunk
Add a binding for fixed/soldered Realtek PCIe Ethernet controllers driven by the r8169 driver (RTL8125/8126/8127/8168 and variants). The "pciVVVV,DDDD" compatibles are the Open Firmware PCI Bus Binding spelling, auto-derived from PCI-SIG vendor/device IDs, but they still need a binding when used in a board DT - analogous to "usbVVVV,PPPP" compatibles documented in their own bindings (e.g. microchip,lan95xx) so board DTs attaching properties (fixed MAC, nvmem cell, ...) to these PCI function nodes can be validated. Suggested-by: Sebastian Reichel <redacted> Signed-off-by: Ricardo Pardini <redacted> --- .../devicetree/bindings/net/realtek,r8169.yaml | 54 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 55 insertions(+)diff --git a/Documentation/devicetree/bindings/net/realtek,r8169.yaml b/Documentation/devicetree/bindings/net/realtek,r8169.yaml new file mode 100644 index 0000000000000..6923211ff4c93 --- /dev/null +++ b/Documentation/devicetree/bindings/net/realtek,r8169.yaml
r8169 but no r8169 devices at all. This must match the device name, so most likely: realtek,rtl8168.yaml
quoted hunk ↗ jump to hunk
@@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/realtek,r8169.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek r8169 family PCIe Ethernet Controllers
rtl8169? 8168? There is no r8169, is there?
+ +maintainers: + - Heiner Kallweit [off-list ref] + +description: + PCI function node properties for fixed/soldered Realtek Ethernet + controllers driven by the r8169 driver.
Describe hardware, not drivers.
+ +allOf: + - $ref: ethernet-controller.yaml# + +properties: + compatible: + enum: + - pci10ec,8125 # RTL8125 2.5GbE + - pci10ec,8126 # RTL8126 5GbE + - pci10ec,8127 # RTL8127 + - pci10ec,8161 # RTL8168 variant + - pci10ec,8162 # RTL8168 variant + - pci10ec,8168 # RTL8168/8111 GbE + + reg: + maxItems: 1 + + local-mac-address: true + mac-address: true + nvmem-cells: true + nvmem-cell-names: true
Drop all above
+ +required: + - compatible + - reg + +additionalProperties: false
uneavaluatedProperties instead Best regards, Krzysztof