Re: [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge
flat view
From: Alex Elder <hidden>
Date: 2026-06-05 12:25:31
Also in:
bpf, linux-arm-kernel, linux-arm-msm, linux-devicetree, linux-gpio, lkml
On 6/4/26 9:40 PM, Rob Herring (Arm) wrote:
On Thu, 04 Jun 2026 20:00:17 -0500, Alex Elder wrote:quoted
From: Daniel Thompson <redacted> Add devicetree bindings for the Toshiba TC956x family of Ethernet-AVB/TSN bridges. The TC9564 contains a PCIe switch with one upstream and three downstream PCIe ports. The third PCIe downstream port has an attached embedded PCIe endpoint, and that endpoint implements two PCIe functions. Each internal PCIe function has a Synopsys XGMAC Ethernet interface capable of 10 Gbps operation. The TC9564 also implements an embedded GPIO controller, which exposes 10 lines externally. Some platforms use these GPIO lines, so this GPIO controller is managed by a separate driver. Other embedded peripherals (like a microcontroller, SRAM, and UART) are currently unused. The GPIO controller is managed by registers accessed via MMIO on an internal PCIe function's registers. Signed-off-by: Daniel Thompson <redacted> Signed-off-by: Alex Elder <redacted> --- .../bindings/net/toshiba,tc9564-dwmac.yaml | 120 ++++++++++++++++++ MAINTAINERS | 6 + 2 files changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yamlMy bot found errors running 'make dt_binding_check' on your patch:
Thank you for this report. After upgrading the "dtschema" package I also see these errors. The "gpio" and "ethernet" properties will have an "unevaluatedProperties: false" constraint added in the next version of this series. The name of the binding file will also be correct in the MAINTAINERS file. -Alex
yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: gpio: Missing additionalProperties/unevaluatedProperties constraint /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml: ethernet: Missing additionalProperties/unevaluatedProperties constraint doc reference errors (make refcheckdocs): Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml MAINTAINERS: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml See https://patchwork.kernel.org/project/devicetree/patch/20260605010022.968612-11-elder@riscstar.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.