Re: Re: [PATCH net v1] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility

-----Original Messages-----
From: "Krzysztof Kozlowski" <krzk@kernel.org>
Send time:Saturday, 30/05/2026 19:18:54
To: lizhi2@eswincomputing.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, pritesh.patel@einfochips.com, weishangjuan@eswincomputing.com, sashiko-bot@kernel.org
Subject: Re: [PATCH net v1] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility

On Mon, May 25, 2026 at 01:24:41PM +0800, lizhi2@eswincomputing.com wrote:

quoted

From: Zhi Li <redacted>

The previous change added two optional cells to

What is previous in this context? There is no previous commit here.

Good point. I'll reword this in v2 to explicitly reference the commit
being fixed.

quoted

eswin,hsp-sp-csr, but omitted minItems: 4.

As a result, dt-schema implicitly required all 6 cells,
breaking backward compatibility with existing 4-cell
device trees.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Thanks, I'll fix the line wrapping in v2 as well.

quoted

Add minItems: 4 to preserve backward compatibility.

Fixes: c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")
Reported-by: Sashiko AI <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/all/20260519022334.35742C2BCB7@smtp.kernel.org/ (local)
Signed-off-by: Zhi Li <redacted>
---

With fixed commit msg:

Reviewed-by: Krzysztof Kozlowski <redacted>

Thanks, I'll carry your Reviewed-by tag in v2.