Re: [PATCH net v1] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-05-30 11:18:56
Also in:
linux-devicetree, lkml
On Mon, May 25, 2026 at 01:24:41PM +0800, lizhi2@eswincomputing.com wrote:
From: Zhi Li <redacted> The previous change added two optional cells to
What is previous in this context? There is no previous commit here.
eswin,hsp-sp-csr, but omitted minItems: 4. As a result, dt-schema implicitly required all 6 cells, breaking backward compatibility with existing 4-cell device trees.
Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Add minItems: 4 to preserve backward compatibility.
Fixes: c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")
Reported-by: Sashiko AI <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/all/20260519022334.35742C2BCB7@smtp.kernel.org/ (local)
Signed-off-by: Zhi Li <redacted>
---With fixed commit msg: Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof