Thread (4 messages) 4 messages, 4 authors, 1d ago

RE: [Intel-wired-lan] [PATCH net-next] net: e100: replace silent 'hope for the best' with debug message

From: Loktionov, Aleksandr <hidden>
Date: 2026-05-22 07:48:34
Also in: intel-wired-lan, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf
Of Ashwin Gundarapu via Intel-wired-lan
Sent: Thursday, May 21, 2026 8:10 AM
To: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; andrewnetdev
[off-list ref]; davem [off-list ref]; edumazet
[off-list ref]; kuba [off-list ref]; pabeni
[off-list ref]
Cc: intel-wired-lan <redacted>; netdev
[off-list ref]; linux-kernel [off-list ref]
Subject: [Intel-wired-lan] [PATCH net-next] net: e100: replace silent
'hope for the best' with debug message

From: Ashwin Gundarapu <redacted>
Date: Sun, 10 May 2026 15:09:12 +0530
Subject: [PATCH] net: e100: replace silent 'hope for the best' with
debug  message

Replace a silent return with a debug message when no MII PHY is
detected on known variants. This gives users visibility into the
failure instead of silently hoping for the best.

Found by checkpatch.pl inspection.

Signed-off-by: Ashwin Gundarapu <redacted>
---
 drivers/net/ethernet/intel/e100.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
index 9074b558de35..bfacf877ca40 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1450,7 +1450,9 @@ static int e100_phy_init(struct nic *nic)
 		 * But do this AFTER MII checking only, since this does
 		 * lookup of EEPROM values which may easily be
unreliable. */
 		if (e100_phy_check_without_mii(nic))
-			return 0; /* simply return and hope for the best
*/
+                        netif_dbg(nic, probe, nic->netdev,
+                                  "No MII PHY detected, continuing
anyway\n");
+                        return 0;
 		else {
Does it compile without } else { ? 

 			/* for unknown cases log a fatal error */
 			netif_err(nic, hw, nic->netdev,
--
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help