Re: [PATCH net-next] net: e100: replace silent 'hope for the best' with debug message
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2026-05-21 12:28:21
Also in:
intel-wired-lan, lkml
Hi, On 5/21/26 08:10, Ashwin Gundarapu wrote:
From: Ashwin Gundarapu <redacted> Date: Sun, 10 May 2026 15:09:12 +0530 Subject: [PATCH] net: e100: replace silent 'hope for the best' with debug message Replace a silent return with a debug message when no MII PHY is detected on known variants. This gives users visibility into the failure instead of silently hoping for the best.
It's not silent actually, e100_phy_check_without_mii() already prints a message when returning 1. Not sure this patch achieves anything meaningful... Maxime
quoted hunk ↗ jump to hunk
Found by checkpatch.pl inspection. Signed-off-by: Ashwin Gundarapu <redacted> --- drivers/net/ethernet/intel/e100.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 9074b558de35..bfacf877ca40 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c@@ -1450,7 +1450,9 @@ static int e100_phy_init(struct nic *nic) * But do this AFTER MII checking only, since this does * lookup of EEPROM values which may easily be unreliable. */ if (e100_phy_check_without_mii(nic)) - return 0; /* simply return and hope for the best */ + netif_dbg(nic, probe, nic->netdev, + "No MII PHY detected, continuing anyway\n"); + return 0; else { /* for unknown cases log a fatal error */ netif_err(nic, hw, nic->netdev,