Thread (19 messages) 19 messages, 4 authors, 2026-03-31

Re: [PATCH net-next v2 00/15] net: stmmac: qcom-ethqos: more cleanups

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-03-31 00:50:40
Also in: linux-arm-kernel, linux-arm-msm

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Fri, 27 Mar 2026 08:42:58 +0000 you wrote:
Further cleanups to qcom-ethqos, mainly concentrating on the RGMII
code, making it clearer what the differences are for each speed, thus
making the code more readable.

I'm still not really happy with this. The speed specific configuration
remains split between ethqos_fix_mac_speed_rgmii() and
ethqos_rgmii_macro_init(), where the latter is only ever called from
the former. So, I think further work is needed here - maybe it needs
restructuring into the various componenet parts of the RGMII block?

[...]
Here is the summary with links:
  - [net-next,v2,01/15] net: stmmac: qcom-ethqos: remove ethqos_configure()
    https://git.kernel.org/netdev/net-next/c/c3dd3b1e76e0
  - [net-next,v2,02/15] net: stmmac: qcom-ethqos: pass ethqos to ethqos_pcs_set_inband()
    https://git.kernel.org/netdev/net-next/c/673416fb5b41
  - [net-next,v2,03/15] net: stmmac: qcom-ethqos: eliminate configure_func
    https://git.kernel.org/netdev/net-next/c/e9ed46a0b129
  - [net-next,v2,04/15] net: stmmac: qcom-ethqos: move detection of invalid RGMII speed
    https://git.kernel.org/netdev/net-next/c/426ce4677e81
  - [net-next,v2,05/15] net: stmmac: qcom-ethqos: move RGMII_CONFIG_DDR_MODE
    https://git.kernel.org/netdev/net-next/c/6be23c4c636a
  - [net-next,v2,06/15] net: stmmac: qcom-ethqos: move 1G vs 100M/10M RGMII settings
    https://git.kernel.org/netdev/net-next/c/82d5fdc82a33
  - [net-next,v2,07/15] net: stmmac: qcom-ethqos: move two more RGMII_IO_MACRO_CONFIG2 out
    https://git.kernel.org/netdev/net-next/c/dd07f2f9149a
  - [net-next,v2,08/15] net: stmmac: qcom-ethqos: move 100M/10M speed programming
    https://git.kernel.org/netdev/net-next/c/8b19a9184420
  - [net-next,v2,09/15] net: stmmac: qcom-ethqos: move RGMII_CONFIG2_RSVD_CONFIG15 out
    https://git.kernel.org/netdev/net-next/c/dae1de3df3e1
  - [net-next,v2,10/15] net: stmmac: qcom-ethqos: move RGMII_CONFIG2_RX_PROG_SWAP
    https://git.kernel.org/netdev/net-next/c/432c8a9f5528
  - [net-next,v2,11/15] net: stmmac: qcom-ethqos: finally eliminate the switch
    https://git.kernel.org/netdev/net-next/c/439a27f21ecc
  - [net-next,v2,12/15] net: stmmac: qcom-ethqos: simplify prg_rclk_dly programming
    https://git.kernel.org/netdev/net-next/c/3df0e86f8f8d
  - [net-next,v2,13/15] net: stmmac: qcom-ethqos: move loopback decision next to reg update
    https://git.kernel.org/netdev/net-next/c/67343aa24e59
  - [net-next,v2,14/15] net: stmmac: qcom-ethqos: correct prg_rclk_dly comment
    https://git.kernel.org/netdev/net-next/c/2d350a892aad
  - [net-next,v2,15/15] net: stmmac: qcom-ethqos: move phase_shift to register update site
    https://git.kernel.org/netdev/net-next/c/7f9f30166005

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help