Re: [PATCH net-next v2 03/15] net: stmmac: qcom-ethqos: eliminate configure_func
flat view
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2026-03-28 07:57:20
Also in:
linux-arm-kernel, linux-arm-msm
On Fri, Mar 27, 2026 at 08:43:38AM +0000, Russell King (Oracle) wrote:
quoted hunk ↗ jump to hunk
@@ -687,7 +683,7 @@ static int ethqos_clks_config(void *priv, bool enabled) /* Enable functional clock to prevent DMA reset to timeout due * to lacking PHY clock after the hardware block has been power * cycled. The actual configuration will be adjusted once - * ethqos_fix_mac_speed() is invoked. + * ethqos' fix_mac_speed() method is invoked.
...
- ethqos->configure_func = ethqos_configure_rgmii; + plat_dat->fix_mac_speed = ethqos_fix_mac_speed_rgmii;
...
- ethqos->configure_func = ethqos_configure_sgmii; + plat_dat->fix_mac_speed = ethqos_fix_mac_speed_sgmii;
AI review of this patch is still complaining about the comment above: The comment still references 'fix_mac_speed() method' but the function ethqos_fix_mac_speed() was removed in this patch. Should this comment be updated to reference either ethqos_fix_mac_speed_rgmii() or ethqos_fix_mac_speed_sgmii(), or perhaps just 'the fix_mac_speed callback' to remain implementation-agnostic? Artifical Stupidity at its best! :/ -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!