RE: [net-next PATCH v2 00/13] net: renesas: rswitch: R-Car S4 add VLAN aware switching

Hello Jakub,

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, March 27, 2026 6:37 PM
To: Michael Dege <redacted>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>; Andrew Lunn <andrew+netdev@lunn.ch>; David
S. Miller [off-list ref]; Eric Dumazet [off-list ref]; Paolo Abeni [off-list ref];
netdev@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v2 00/13] net: renesas: rswitch: R-Car S4 add VLAN aware switching

On Fri, 27 Mar 2026 09:27:30 +0100 Michael Dege wrote:

quoted

Hello!

The current R-Car S4 rswitch driver only supports basic HW offloading
for L2 switching/bridgeing. This patchset extends the driver with
support for VLAN aware switching.

1. For every port mode change from configuration to operation and
   vice-versa you need to change to disabled mode first. The
   functions rswitch_<port>_change_mode now take care of this.

2. In upcomming changes for adding vlan support struct net_device
   will not be available in all cases, therefore use struct device
   instead.

3. Fix typo in register define macro and remove duplicate macro.

4. Add register definitions needed fo vlan support.

5. Add exception path for packets with unknown destitination MAC
   addresses.

6. Make the helper functions rswitch_reg_wait(),
   rswitch_etha_change_mode() and rswitch_etha_change_mode()
   available to the whole driver.

7. Add basic start-up time initialization needed to support VLANs.

8. Update ETHA and GWCA port HW initializations.

9. Clean up is_rdev() rswitch_device checking.

10. Provide struct rswitch_private to notifiers.

11. Add handler for FDB notifications to configure bridge MAC address
    to GWCA registers and update static MAC table entry.

12. Add vlan support to L2 HW bridge.

coccicheck reports:

drivers/net/ethernet/renesas/rswitch_main.c:1590:11-66: duplicated argument to & or | @@ -182,0 +184,3
@@
drivers/net/ethernet/renesas/rswitch_l2.c:350:5-8: WARNING: Unsigned expression compared with zero:
err < 0
drivers/net/ethernet/renesas/rswitch_l2.c:380:5-8: WARNING: Unsigned expression compared with zero:
err < 0
drivers/net/ethernet/renesas/rswitch_l2.c:465:5-8: WARNING: Unsigned expression compared with zero:
err < 0

Thank you very much for pointing these out to me.

Best regards,

Michael

reminder: please do not post a new version of patches on netdev earlier than a full 24h after previous
posting.