Re: [PATCH net-next v2 13/13] net: renesas: rswitch: add vlan aware switching

Hi Michael,

kernel test robot noticed the following build errors:

[auto build test ERROR on 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Dege/net-renesas-rswitch-improve-port-change-mode-functions/20260329-154812
base:   1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
patch link:    https://lore.kernel.org/r/20260327-rswitch_add_vlans-v2-13-d7f4358ca57a%40renesas.com
patch subject: [PATCH net-next v2 13/13] net: renesas: rswitch: add vlan aware switching
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20260330/202603300436.ryIgiB0z-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260330/202603300436.ryIgiB0z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202603300436.ryIgiB0z-lkp@intel.com/ (local)

All errors (new ones prefixed by >>):

   aarch64-linux-ld: Unexpected GOT/PLT entries detected!
   aarch64-linux-ld: Unexpected run-time procedure linkages detected!
   aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.o: in function `rswitch_port_obj_do_add_gwca':

quoted

drivers/net/ethernet/renesas/rswitch_l2.c:443:(.text+0x11e0): undefined reference to `br_vlan_enabled'

   aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.o: in function `rswitch_port_obj_do_add':
   drivers/net/ethernet/renesas/rswitch_l2.c:412:(.text+0x135c): undefined reference to `br_vlan_enabled'

quoted

aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.c:423:(.text+0x13bc): undefined reference to `br_vlan_enabled'

vim +443 drivers/net/ethernet/renesas/rswitch_l2.c

   402	
   403	static int rswitch_port_obj_do_add(struct net_device *ndev,
   404					   struct switchdev_obj_port_vlan *p_vlan)
   405	{
   406		struct rswitch_device *rdev = netdev_priv(ndev);
   407		struct rswitch_private *priv = rdev->priv;
   408		struct rswitch_etha *etha = rdev->etha;
   409		int err;
   410	
   411		/* Set Rswitch VLAN mode */
   412		iowrite32(br_vlan_enabled(rdev->brdev) ? FIELD_PREP(FWGC_SVM, C_TAG) : 0,
   413			  priv->addr + FWGC);
   414	
   415		err = rswitch_write_vlan_table(priv, p_vlan->vid, etha->index);
   416		if (err < 0)
   417			return err;
   418	
   419		/* If the default vlan for this port has been set, don't overwrite it. */
   420		if (ioread32(etha->addr + EAVCC))
   421			return NOTIFY_DONE;
   422	
 > 423		if (br_vlan_enabled(rdev->brdev))
   424			rswitch_modify(priv->addr, FWPC0(etha->index), 0, FWPC0_VLANSA | FWPC0_VLANRU);
   425	
   426		rswitch_modify(priv->addr, FWPC2(AGENT_INDEX_GWCA),
   427			       FIELD_PREP(FWPC2_LTWFW, BIT(etha->index)),
   428			       0);
   429	
   430		return rswitch_port_set_vlan_tag(etha, p_vlan, false);
   431	}
   432	
   433	static int rswitch_port_obj_do_add_gwca(struct net_device *ndev,
   434						struct rswitch_private *priv,
   435						struct switchdev_obj_port_vlan *p_vlan)
   436	{
   437		int err;
   438	
   439		if (!(p_vlan->flags & BRIDGE_VLAN_INFO_BRENTRY))
   440			return NOTIFY_DONE;
   441	
   442		/* Set Rswitch VLAN mode */
 > 443		iowrite32(br_vlan_enabled(ndev) ? FIELD_PREP(FWGC_SVM, C_TAG) : 0, priv->addr + FWGC);
   444	
   445		err = rswitch_write_vlan_table(priv, p_vlan->vid, AGENT_INDEX_GWCA);
   446		if (err < 0)
   447			return err;
   448	
   449		/* If the default vlan for this port has been set, don't overwrite it. */
   450		if (ioread32(priv->addr + GWVCC))
   451			return NOTIFY_DONE;
   452	
   453		return rswitch_gwca_set_vlan_tag(priv, p_vlan, false);
   454	}
   455	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki