On Fri, Mar 27, 2026 at 02:39:24PM +0100, Krzysztof Kozlowski wrote:

On 23/03/2026 13:50, Sumit Garg wrote:

quoted

quoted

quoted

+
+#include <linux/device/devres.h>
+#include <linux/firmware/qcom/qcom_pas.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+#include "qcom_pas.h"
+
+struct qcom_pas_ops *ops_ptr;

Should this be static ?

It was static earlier in v1. I dropped it based on earlier v1 discussion
with Krzysztof. Let me conclude that discussion on the other thread
again.

The discussion was whether this should be singleton in the first place,
not making it a global singleton.

Of course it cannot be anything else than static - nothing should poke here.

Sure, I have put the static back for v3.

-Sumit