Thread (41 messages) 41 messages, 6 authors, 2026-03-30

Re: [PATCH v2 02/15] firmware: qcom: Add a generic PAS service

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-27 13:39:36
Also in: ath12k, dri-devel, linux-arm-msm, linux-devicetree, linux-media, linux-remoteproc, linux-wireless, lkml

On 23/03/2026 13:50, Sumit Garg wrote:
quoted
quoted
+
+#include <linux/device/devres.h>
+#include <linux/firmware/qcom/qcom_pas.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+#include "qcom_pas.h"
+
+struct qcom_pas_ops *ops_ptr;
Should this be static ?
It was static earlier in v1. I dropped it based on earlier v1 discussion
with Krzysztof. Let me conclude that discussion on the other thread
again.
The discussion was whether this should be singleton in the first place,
not making it a global singleton.

Of course it cannot be anything else than static - nothing should poke here.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help