Re: [PATCH] device property: Make modifications of fwnode "flags" thread safe
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-03-17 10:17:00
Also in:
driver-core, imx, linux-acpi, linux-arm-kernel, linux-devicetree, linux-i2c, linux-spi, lkml, stable
On Tue, Mar 17, 2026 at 09:42:38AM +0100, Wolfram Sang wrote:
quoted
quoted
What's the alignment for the u8 member in your SoC? 4 bytes or 8 bytes? (I assume it's 64-bit SoC.)FWIW, with the given change it will be still inside 64-byte data structure which most likely occupies a single cache line (before this patch and after as well).I consider this directon of the discussion irrelevant. If the number is (maybe? That's to be discussed!) needlessly bigger than 0, then it doesn't matter how big the number is.
That's why it was written 'FWIW', so it doesn't worth :-)
Why don't you like the idea of taking the lock?
Like Danilo I am also not sure what lock protects fwnode accesses. -- With Best Regards, Andy Shevchenko