Thread (16 messages) 16 messages, 7 authors, 2026-03-18

Re: [PATCH] device property: Make modifications of fwnode "flags" thread safe

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-03-17 07:34:29
Also in: driver-core, imx, linux-acpi, linux-arm-kernel, linux-devicetree, linux-i2c, linux-spi, lkml, stable

On Tue, Mar 17, 2026 at 08:26:53AM +0100, Wolfram Sang wrote:

...
Thanks for tackling this issue! I agree it should be fixed, just
wondered about one thing:
quoted
While flags are often modified while under the "fwnode_link_lock",
this is not universally true.
Is it a possibility to use the lock in all code paths instead?
Because...
quoted
 	struct list_head consumers;
-	u8 flags;
+	unsigned long flags;
... this change costs some memory on every system. Maybe it can be
avoided?
How much memory does it cost? On most 64-bit architectures is +4 bytes,
rarely +0 bytes, on m68k it might be +2bytes. On 32-bit it most likely
+0 bytes. I expect that 64-bit machines will cope with this bump.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help