Re: [PATCH net 3/3] amd-xgbe: reset PHY settings before starting PHY

From
Maxime Chevallier <maxime.chevallier@bootlin.com>
Date
2026-03-04 13:44:38
Also in
lkml
Reply to
Raju Rangoju, 2026-03-04
Hi Raju,

On 04/03/2026 13:23, Raju Rangoju wrote:
commit f93505f35745 ("amd-xgbe: let the MAC manage PHY PM") moved
xgbe_phy_reset() from xgbe_open() to xgbe_start(), placing it after
phy_start(). As a result, the PHY settings were being reset after the
PHY had already started.

Reorder the calls so that the PHY settings are reset before
phy_start() is invoked.

Fixes: f93505f35745 ("amd-xgbe: let the MAC manage PHY PM")
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
This looks good to me,

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime
Thread (6 messages) 6 messages, 2 authors, last reply 2026-03-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help