Thread (50 messages) 50 messages, 8 authors, 2026-03-24

Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings

flat view

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-03-03 14:18:54
Also in: linux-devicetree, lkml

quoted hunk ↗ jump to hunk
+        properties:
+          microchip,led-drive-mode:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description: |
+              Set the LED drive mode for the copper PHY associated with
+              this port.
+
+                0 - LED1 and LED2 in open-drain mode
+                1 - LED1 in active drive mode (can be used for single-LED
+                    configurations requiring active drive)
+                2 - Reserved
+                3 - LED1 and LED2 in active drive mode
+            minimum: 0
+            maximum: 3
I doubt the DT Maintainers will accept that. This looks a lot like a
value you write into a register. How are active drive and open-drain
described in other DT bindings? Is there something you can reuse?

For 1, what happens to LED2? Not used at all?

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help