Re: [PATCH net-next 4/5] selftests: forwarding: extend ethtool_std_stats_get with pause statistics
From: Petr Machata <petrm@nvidia.com>
Date: 2026-02-27 17:02:22
Also in:
linux-kselftest, lkml
Ioana Ciornei [off-list ref] writes:
quoted hunk ↗ jump to hunk
Even though pause frame statistics are not exported through the same ethtool command, there is no point in adding another helper just for them. Extent the ethtool_std_stats_get() function so that we are able to interrogate using the same helper all the standard statistics. Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- tools/testing/selftests/net/forwarding/lib.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index a9034f0bb58b..efd236ae1c28 100644 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh@@ -831,8 +831,12 @@ ethtool_std_stats_get() local name=$1; shift local src=$1; shift - ethtool --json -S $dev --groups $grp -- --src $src | \ - jq '.[]."'"$grp"'"."'$name'"' + if [[ "$grp" == "pause" ]]; then + ethtool -I --json -a $dev | jq '.[].statistics.'$name
I think name needs to be quoted here? In fact, unless the pause group is
highly unlikely to ever get a key that contains a dash, it should either
be quoted in the horrible way the else branch does it, or do this much
more readable thing instead:
jq --arg name "$name" '.[].statistics[$name]'
+ else + ethtool --json -S $dev --groups $grp -- --src $src | \
Since you are touching this line -- can you fix the missing quoting, please?
+ jq '.[]."'"$grp"'"."'$name'"' + fi } qdisc_stats_get()