Thread (34 messages) 34 messages, 6 authors, 2026-03-03

Re: [PATCH net-next 5/5] selftests: drivers: hw: add tests for the ethtool standard counters

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-02-25 23:39:08
Also in: linux-kselftest, lkml

On Wed, Feb 25, 2026 at 05:06:48PM +0200, Ioana Ciornei wrote:
Add a new selftest - ethtool_std_stats.sh - which validates the
eth-ctrl, eth-mac and pause standard statistics exported by an
interface. Not all counters can be validated in software, especially
those that are keeping track of errors. Counters such as
SingleCollisionFrames, FrameCheckSequenceErrors etc are not tested nor
included in this new selftest.
Hi Ioana

Thanks for the test!

Do we actually expect errors when running such a test? How many times
have you run this test and seen any of the error counters be anything
other than 0?

Which do you think is more likely:

1) A real error happens

2) Bug in the driver so that it reports a value in the wrong place?

Maybe we should check the error counters are zero? 

      Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help