Re: [PATCH] net: phy: qcom: qca807x: normalize return value of gpio_get
From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-02-19 10:48:06
Also in:
linux-arm-msm, linux-gpio, lkml
On Wed, 18 Feb 2026 21:57:17 +0100, Dmitry Torokhov [off-list ref] said:
quoted hunk ↗ jump to hunk
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by qca807x_gpio_get() is normalized to the [0, 1] range. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- [First copy went to Andrew privately by mistake] drivers/net/phy/qcom/qca807x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/phy/qcom/qca807x.c b/drivers/net/phy/qcom/qca807x.c index d8f1ce5a7128..6004da5741af 100644 --- a/drivers/net/phy/qcom/qca807x.c +++ b/drivers/net/phy/qcom/qca807x.c@@ -375,7 +375,7 @@ static int qca807x_gpio_get(struct gpio_chip *gc, unsigned int offset) reg = QCA807X_MMD7_LED_FORCE_CTRL(offset); val = phy_read_mmd(priv->phy, MDIO_MMD_AN, reg); - return FIELD_GET(QCA807X_GPIO_FORCE_MODE_MASK, val); + return !!FIELD_GET(QCA807X_GPIO_FORCE_MODE_MASK, val); } static int qca807x_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) --2.53.0.335.g19a08e0c02-goog -- Dmitry
Reviewed-by: Bartosz Golaszewski <redacted>