Re: [PATCH] net: phy: qcom: qca807x: normalize return value of gpio_get
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2026-02-18 23:01:26
Also in:
linux-arm-msm, linux-gpio, lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2026-02-18 23:01:26
Also in:
linux-arm-msm, linux-gpio, lkml
On February 18, 2026 2:55:32 PM PST, Andrew Lunn [off-list ref] wrote:
On Wed, Feb 18, 2026 at 12:57:17PM -0800, Dmitry Torokhov wrote:quoted
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by qca807x_gpio_get() is normalized to the [0, 1] range. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>This appears to be a fix. Please add a Fixes: tag. Also, please put net into the Subject. https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Will do, however I am not sure what should be tagged as "Fixes" - original driver commit or the change in gpiolib tightening the checks? Thanks! -- Dmitry