Re: [PATCH] net: usb: kaweth: remove TX queue manipulation in kaweth_set_rx_mode
From: Ziyi Guo <hidden>
Date: 2026-02-17 16:48:25
Also in:
linux-usb, lkml
From: Ziyi Guo <hidden>
Date: 2026-02-17 16:48:25
Also in:
linux-usb, lkml
On Tue, Feb 17, 2026 at 3:56 AM Paolo Abeni [off-list ref] wrote:
On 2/17/26 9:50 AM, Paolo Abeni wrote:quoted
It looks like kaweth_set_rx_mode() is already functionally broken: the real set_rx_mode action is performed by kaweth_async_set_rx_mode, which in turn is not a no-op only at ndo_open() time. So this looks safe to me.@Ziyi Guo: I'm sorry I'm low on coffee and I did not notice a couple of relevant things. This needs a fixes tag. Also please specify the target tree ('net' in this case) on re-submit.
Hi Paolo and other folks, thank you so much for your time and review, and sure, I'll revise and send a v2 version patch, with the fixes tag and target tree.