Thread (6 messages) 6 messages, 3 authors, 2026-02-17

Re: [PATCH] net: usb: kaweth: remove TX queue manipulation in kaweth_set_rx_mode

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-02-09 13:56:11
Also in: linux-usb, lkml

On Mon, Feb 09, 2026 at 05:30:13AM +0000, Ziyi Guo wrote:
kaweth_set_rx_mode(), the ndo_set_rx_mode callback, calls
netif_stop_queue() and netif_wake_queue(). These are TX queue flow
control functions unrelated to RX multicast configuration.
I think there needs to be a better explanation why it is safe to
remove these stop and wake queue operations. r8152 does the same. Is
it also broken? Rather than removing these, should we actually be
waiting for the completion of the urb?

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help