Re: [PATCH v2 00/25] kernel-doc: make it parse new functions and structs
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Date: 2026-02-10 15:27:54
Also in:
bpf, intel-wired-lan, linux-doc, lkml
On Wed, 28 Jan 2026 10:27:58 -0700 Jonathan Corbet [off-list ref] wrote:
Mauro Carvalho Chehab [off-list ref] writes:quoted
Hi Jon, It is impressive how a single patch became a series with 25 ones ;-)*sigh* I will try to have a good look at these shortly. It seems pretty clear that this isn't 7.0 material at this point, though.
I ended missing your e-mail... Yeah, it is too late for 7.0.
One thing that jumped at me:quoted
Ah, due to the complexity of NestedMatch, I opted to write some unit tests to verify that the logic there is correct. We can use it to add other border cases. Using it is as easy as running: $ tools/unittests/nested_match.py (I opted to create a separate directory for it, as this is not really documentation)Do we really need another unit-testing setup in the kernel? I can't say I'm familiar enough with kunit to say whether it would work for non-kernel code; have you looked and verified that it isn't suitable?
I'm familiar with kunit: I wrote myself a bunch of tests using it for some DRM stuff. Kunit is focused on testing kernel content. It basically adds a way for a python script to run self-test logic inside a kernel module. It is not meant to test things outside the Kernel. Also, I'm using the python internal library for it. The only "fancy" thing I added is a helper module to better work with unit tests: - it formats unittest output; - it passes some parameters to the unittest discover to make it more useable; - it adds argparse parameters to filter tests and control their verbosity levels; - it adds a way to pass argparse values to the tests, as some tests may require parameters (like passing a different yaml file to a dynamically-generated unit test). - Anyway, I intend to send a new version of this series either later this week or at the next one. I'll probably split the unittest part from the part meant to avoid new warnings after merging from linux-next. -- Thanks, Mauro