Re: Re: [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2026-02-10 12:30:38
Also in:
linux-arm-kernel, linux-devicetree, lkml
Hi, On Tue, Feb 10, 2026 at 06:21:40PM +0800, 李志 wrote:
quoted
-----原始邮件----- 发件人: "Russell King (Oracle)" [off-list ref] 发送时间:2026-02-09 22:31:28 (星期一) 收件人: lizhi2@eswincomputing.com, "Andrew Lunn" [off-list ref] 抄送: devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, weishangjuan@eswincomputing.com 主题: Re: [PATCH v2 0/2] net: stmmac: eic7700: fix EIC7700 eth1 RX sampling timing On Mon, Feb 09, 2026 at 02:36:11PM +0100, Andrew Lunn wrote:quoted
On Mon, Feb 09, 2026 at 05:46:28PM +0800, lizhi2@eswincomputing.com wrote:quoted
From: Zhi Li <redacted> v1 -> v2:For version 3, please include a patch to the SoC .dtsi file adding the Ethernet nodes. We like to see users of code being added.In addition to Andrew's comments, before posting another series, please review https://docs.kernel.org/process/maintainer-netdev.html, particularly sections 1.4 and 1.6.1.Thanks for the comments. The v3 patch will target the net git tree.
While it may be a fix, given that:
We will add the ethernet nodes and the corresponding clock node to eic7700.dtsi and eic7700-hifive-premier-p550.dts in v3 patch. Please note that the EIC7700 clock controller binding and driver are not yet merged upstream, so the clock nodes will not be functional until the clock driver is available. As a result, dtbs_check will currently report schema warnings/errors related to the clock nodes. This is a known and temporary limitation until the clock binding and driver are available upstream.
I don't see much point to putting it in the net tree - you're addressing problems with a driver that is currently not in a usable state in mainline, so there's no need to rush to have this change in mainline. I think the net-next tree will do once it re-opens after v7.0-rc1 has been released. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!