Re: [PATCH v2 1/2] dt-bindings: ethernet: eswin: add clock sampling control
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-02-09 13:21:49
Also in:
linux-arm-kernel, linux-devicetree, lkml
The rx-internal-delay-ps and tx-internal-delay-ps properties now use minimum and maximum constraints to reflect the actual hardware delay range (0-2400 ps) applied in 20 ps steps.
rx-internal-delay-ps: - enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400] + minimum: 0 + maximum: 2400
multipleOf: 20
Also, 2400 / 20 = 120. Is the real maximum 127 * 20 = 2540?
quoted hunk ↗ jump to hunk
@@ -111,17 +129,44 @@ examples: interrupts = <61>; interrupt-names = "macirq"; phy-mode = "rgmii-id"; - phy-handle = <&phy0>; + phy-handle = <&gmac0_phy0>; resets = <&reset 95>; reset-names = "stmmaceth"; + rx-internal-delay-ps = <20>; + tx-internal-delay-ps = <100>;
I would not include them in the example. You are going to get developers blindly copying this into real DT. A well designed board should not need delays. Andrew