Thread (5 messages) flat view 5 messages, 3 authors, 2026-02-04

Re: [PATCH net-next v1] icmp: fix ip_rt_bug race in icmp_route_lookup reverse path

From: David Ahern <dsahern@kernel.org>
Date: 2026-02-04 16:29:20
Also in: lkml

On 2/3/26 7:27 PM, Jiayuan Chen wrote:
Thanks for the review.

Paolo, I'll fix it in newer version.

Regarding David's question about whether the message provides value:
I think it could still be useful for debugging. If a user's configuration
change causes ICMP packets to be silently dropped, there's currently no counter
or indication of what happened. Adding a dedicated counter for this rare race
condition seems overkill, so a rate-limited warning at least gives some visibility
into the failure.

That said, I'm open to dropping the message entirely if you both think silent handling
is preferred. Let me know and I'll send a new version either way.
no strong opinions.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help