Thread (18 messages) 18 messages, 4 authors, 2026-02-19

Re: [PATCH v2 net-next 11/11] netfilter: nft_set_rbtree: validate open interval overlap

From: Florian Westphal <fw@strlen.de>
Date: 2026-02-10 15:29:49
Also in: netfilter-devel

Paolo Abeni [off-list ref] wrote:
On 2/6/26 4:30 PM, Florian Westphal wrote:
quoted
@@ -515,6 +553,12 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set,
 	    nft_rbtree_interval_end(rbe_ge) && nft_rbtree_interval_end(new))
 		return -ENOTEMPTY;
 
+	/* - start element overlaps an open interval but end element is new:
+	 *   partial overlap, reported as -ENOEMPTY.
AI noticed a typo above, should be: -ENOTEMPTY.

Given the timeline, a repost will land into the next cycle. I guess it's
better to merge this as-is and eventually follow-up later.
Thanks.  Comments are for humans not machines so I think its fine.

That said, I will try to set up some form of AI code review here for
future MRs.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help