[PATCH net-next] net: usb: sr9700: use ETH_ALEN instead of magic number
From: Ethan Nelson-Moore <hidden>
Date: 2026-01-23 07:06:51
Also in:
linux-usb
Subsystem:
networking drivers, the rest, usb networking drivers · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
The driver hardcodes the number 6 as the number of bytes to write to the SR_PAR register, which stores the MAC address. Use ETH_ALEN instead to make the code clearer. Signed-off-by: Ethan Nelson-Moore <redacted> --- drivers/net/usb/sr9700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index 9c7cd0db1768..446857de8e15 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/sr9700.c@@ -271,7 +271,7 @@ static int sr9700_set_mac_address(struct net_device *netdev, void *p) } eth_hw_addr_set(netdev, addr->sa_data); - sr_write_async(dev, SR_PAR, 6, netdev->dev_addr); + sr_write_async(dev, SR_PAR, ETH_ALEN, netdev->dev_addr); return 0; }
--
2.43.0