RE: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases

---Original Message-----

From: Neal Cardwell <ncardwell@google.com>
Sent: Friday, January 9, 2026 12:21 AM
To: Chia-Yu Chang (Nokia) <redacted>
Cc: pabeni@redhat.com; edumazet@google.com; parav@nvidia.com; linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@google.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; Koen De Schepper (Nokia) <redacted>; g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire <redacted>; rs.ietf@gmx.at; Jason_Livingood@comcast.com; Vidhi Goel <redacted>; Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next 1/1] selftests/net: Add packetdrill packetdrill cases


CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



On Thu, Jan 8, 2026 at 5:46 PM Neal Cardwell [off-list ref] wrote:

quoted

On Thu, Jan 8, 2026 at 10:58 AM [off-list ref] wrote:

quoted

From: Chia-Yu Chang <redacted>

Linux Accurate ECN test sets using ACE counters and AccECN options
to cover several scenarios: Connection teardown, different ACK
conditions, counter wrapping, SACK space grabbing, fallback schemes,
negotiation retransmission/reorder/loss, AccECN option drop/loss,
different handshake reflectors, data with marking, and different sysctl values.

Co-developed-by: Ilpo Järvinen <ij@kernel.org>
Signed-off-by: Ilpo Järvinen <ij@kernel.org>
Co-developed-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
---

Chia-Yu, thank you for posting the packetdrill tests.

A couple thoughts:

(1) These tests are using the experimental AccECN packetdrill support
that is not in mainline packetdrill yet. Can you please share the
github URL for the version of packetdrill you used? I will work on
merging the appropriate experimental AccECN packetdrill support into
the Google packetdrill mainline branch.

Oh, for that part I see you mentioned this already in the cover letter:

  The used packetdrill is commit 6f2116af6b7e1936a53e80ab31b77f74abda1aaa
  of the branch: https://github.com/minuscat/packetdrill_accecn

Thanks!
neal

Hi Neal,

You're right, I will change the tile into "selftests/net: Add AccECN packetdrill cases"
And this packetdrill is forked from branch "l4s-packetdrill-2022-08-21-v1"  of https://github.com/google/bbr.git

If you would like me to test on newer packetdrill, feel free to let me know.

Thanks.
Chia-Yu