Re: Re: Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling control
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-01-23 03:19:24
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-01-23 03:19:24
Also in:
linux-arm-kernel, linux-devicetree, lkml
quoted
You say internal. So the skew is fixed, it is a property of the silicon? If so, why a DT property? Why not just hard code it in the driver? Since it is internal, different boards should not need it set differently?Thanks for the question. EIC7700 has two Ethernet MACs. Only eth1 has this internal RXC/RXD skew, eth0 does not. So this is not a chip-wide constant that can be hardcoded in the driver. We need a way to distinguish the two MAC instances, which is why this is described per-port in DTS.
I assume the address of the interface is fixed. So you can just key
off that to distinguish the two instances.
Since this is an internal property, not a board property, it is not
clear it actually belongs on DT.
Andrew