Re: Re: Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling control
From: 李志 <hidden>
Date: 2026-01-23 03:00:51
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: 李志 <hidden>
Date: 2026-01-23 03:00:51
Also in:
linux-arm-kernel, linux-devicetree, lkml
-----原始邮件----- 发件人: "Andrew Lunn" [off-list ref] 发送时间:2026-01-22 21:32:34 (星期四) 收件人: 李志 [off-list ref] 抄送: devicetree@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, weishangjuan@eswincomputing.com 主题: Re: Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling controlquoted
On EIC7700, RXC and RXD experience an internal skew before reaching the MAC. At high speed, this can shift the effective sampling point by approximately half a cycle, causing the MAC to sample the wrong nibble on each edge.You say internal. So the skew is fixed, it is a property of the silicon? If so, why a DT property? Why not just hard code it in the driver? Since it is internal, different boards should not need it set differently?
Thanks for the question. EIC7700 has two Ethernet MACs. Only eth1 has this internal RXC/RXD skew, eth0 does not. So this is not a chip-wide constant that can be hardcoded in the driver. We need a way to distinguish the two MAC instances, which is why this is described per-port in DTS. -- Li Zhi