Re: [PATCH net 1/2] net: ethernet: ave: Remove unnecessary 'out of memory' message

On Fri, Jan 09, 2026 at 09:27:03AM +0900, Kunihiko Hayashi wrote:

Hi Andrew,

On 2026/01/09 3:32, Andrew Lunn wrote:

quoted

On Thu, Jan 08, 2026 at 03:46:40PM +0900, Kunihiko Hayashi wrote:

quoted

Follow the warning from checkpatch.pl and remove 'out of memory'

message.

quoted

     WARNING: Possible unnecessary 'out of memory' message
     #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
     +               if (!skb) {
     +                       netdev_err(ndev, "can't allocate skb for

Rx\n");

Please take a read of

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You tagged this for net, not net-next. I would say this is not a fix.

Thank you for pointing out.
I thought this was a "fix" for the warning, however, it's not a logical
fix. So I'll repost it as net-next.

You might want to read:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

One key thing in that document is:

   It must either fix a real bug that bothers people or just add a device ID

Multiple messages that the system is out of people does not bother
people.

	Andrew