Thread (7 messages) flat view 7 messages, 3 authors, 2026-01-09

Re: [PATCH net 1/2] net: ethernet: ave: Remove unnecessary 'out of memory' message

From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Date: 2026-01-09 00:27:03
Also in: lkml

Hi Andrew,

On 2026/01/09 3:32, Andrew Lunn wrote:
On Thu, Jan 08, 2026 at 03:46:40PM +0900, Kunihiko Hayashi wrote:
quoted
Follow the warning from checkpatch.pl and remove 'out of memory'
message.
quoted
     WARNING: Possible unnecessary 'out of memory' message
     #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
     +               if (!skb) {
     +                       netdev_err(ndev, "can't allocate skb for
Rx\n");

Please take a read of

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You tagged this for net, not net-next. I would say this is not a fix.
Thank you for pointing out.
I thought this was a "fix" for the warning, however, it's not a logical
fix. So I'll repost it as net-next.

Thank you,

---
Best Regards
Kunihiko Hayashi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help