Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version
From: ALOK TIWARI <hidden>
Date: 2026-01-30 13:40:35
On 1/30/2026 6:36 PM, Bhargava Chenna Marreddy wrote:
quoted
On 1/30/2026 2:05 PM, Vikas Gupta wrote:quoted
quoted
drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c index a987afebd64d..57db3caabcfb 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c@@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink, DEVLINK_INFO_VERSION_GENERIC_FW, buf); if (rc) { NL_SET_ERR_MSG_MOD(extack, - "Failed to set roce firmware version"); + "Failed to set generic firmware version");Thanks for fixing. I believe instead of generic, "Failed to set firmware version" is enough.ACK. will send v2.Should this be a candidate for net with a Fixes tag?
I am open to either approach. It does not break functionality, but the current message can be misleading so I am happy to tag it for net if you think it’s appropriate.
Thanks, Bhargava Marreddy
Thanks, Alok