Thread (7 messages) 7 messages, 4 authors, 2026-01-31

Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version

From: Bhargava Chenna Marreddy <hidden>
Date: 2026-01-30 13:07:14

On Fri, Jan 30, 2026 at 2:11 PM ALOK TIWARI [off-list ref] wrote:


On 1/30/2026 2:05 PM, Vikas Gupta wrote:
quoted
quoted
  drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
index a987afebd64d..57db3caabcfb 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
@@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
                               DEVLINK_INFO_VERSION_GENERIC_FW, buf);
         if (rc) {
                 NL_SET_ERR_MSG_MOD(extack,
-                                  "Failed to set roce firmware version");
+                                  "Failed to set generic firmware version");
Thanks for fixing. I believe instead of generic, "Failed to set
firmware version"  is enough.
ACK. will send v2.
Should this be a candidate for net with a Fixes tag?

Thanks,
Bhargava Marreddy
quoted
quoted
                 return rc;
         }

--
Thanks,
Alok

Attachments

  • smime.p7s [application/pkcs7-signature] 5496 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help