Thread (7 messages) 7 messages, 4 authors, 2026-01-04

Re: [PATCH net] net: wwan: iosm: Fix memory leak in ipc_mux_deinit()

From: Markus Elfring <hidden>
Date: 2025-12-30 09:42:39
Also in: kernel-janitors, lkml

quoted
quoted
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux.c
@@ -456,6 +456,7 @@ void ipc_mux_deinit(struct iosm_mux *ipc_mux)
 	struct sk_buff_head *free_list;
 	union mux_msg mux_msg;
 	struct sk_buff *skb;
+	int i;
…

May this variable be defined in the loop header instead?
Thanks for the suggestion.

I would prefer to keep the declaration at the top of the block
Do you tend to interpret such information still as the beginning
of the function implementation?

                                                               to maintain 
consistency with the existing coding style of this function and to keep 
the patch focused strictly on the fix.
Would the mentioned variable be relevant only for an additional if branch?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help