Thread (7 messages) 7 messages, 4 authors, 2026-01-04

Re: [PATCH net] net: wwan: iosm: Fix memory leak in ipc_mux_deinit()

From: Zilin Guan <hidden>
Date: 2025-12-30 09:25:37
Also in: kernel-janitors, lkml

On Tue, Dec 30, 2025 at 10:15:05AM+0100, Markus Elfring wrote:
quoted
+++ b/drivers/net/wwan/iosm/iosm_ipc_mux.c
@@ -456,6 +456,7 @@ void ipc_mux_deinit(struct iosm_mux *ipc_mux)
 	struct sk_buff_head *free_list;
 	union mux_msg mux_msg;
 	struct sk_buff *skb;
+	int i;
…

May this variable be defined in the loop header instead?

Regards,
Markus
Thanks for the suggestion.

I would prefer to keep the declaration at the top of the block to maintain 
consistency with the existing coding style of this function and to keep 
the patch focused strictly on the fix.

Regards,
Zilin Guan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help