Thread (30 messages) 30 messages, 12 authors, 2025-12-18

Re: [PATCH 14/14] net: bridge: Describe @tunnel_hash member in net_bridge_vlan_group struct

From: Ido Schimmel <idosch@nvidia.com>
Date: 2025-12-16 08:10:53
Also in: amd-gfx, bridge, dri-devel, linux-fsdevel, linux-media, linux-mm, lkml, virtualization

On Mon, Dec 15, 2025 at 06:39:02PM +0700, Bagas Sanjaya wrote:
quoted hunk ↗ jump to hunk
Sphinx reports kernel-doc warning:

WARNING: ./net/bridge/br_private.h:267 struct member 'tunnel_hash' not described in 'net_bridge_vlan_group'

Fix it by describing @tunnel_hash member.

Fixes: efa5356b0d9753 ("bridge: per vlan dst_metadata netlink support")
Signed-off-by: Bagas Sanjaya <redacted>
---
 net/bridge/br_private.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 7280c4e9305f36..bf441ac1c4d38a 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -247,6 +247,7 @@ struct net_bridge_vlan {
  * struct net_bridge_vlan_group
  *
  * @vlan_hash: VLAN entry rhashtable
+ * @tunnel_hash: tunnel rhashtable
While you are at it, I suggest making the comment a bit more useful.
Something like:

@tunnel_hash: Hash table to map from tunnel key ID (e.g., VXLAN VNI) to VLAN
  * @vlan_list: sorted VLAN entry list
  * @num_vlans: number of total VLAN entries
  * @pvid: PVID VLAN id
-- 
An old man doll... just what I always wanted! - Clara
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help