Re: [PATCH 06/14] virtio: Describe @map and @vmap members in virtio_device struct
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2025-12-15 20:42:01
Also in:
amd-gfx, bridge, dri-devel, linux-fsdevel, linux-media, linux-mm, lkml, virtualization
On Mon, Dec 15, 2025 at 06:38:54PM +0700, Bagas Sanjaya wrote:
Sphinx reports kernel-doc warnings:
WARNING: ./include/linux/virtio.h:181 struct member 'map' not described in 'virtio_device'
WARNING: ./include/linux/virtio.h:181 struct member 'vmap' not described in 'virtio_device'
Describe these members.
Fixes: bee8c7c24b7373 ("virtio: introduce map ops in virtio core")
Signed-off-by: Bagas Sanjaya <redacted>Acked-by: Michael S. Tsirkin <mst@redhat.com>
quoted hunk ↗ jump to hunk
--- include/linux/virtio.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 132a474e59140a..68ead8fda9c921 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h@@ -150,11 +150,13 @@ struct virtio_admin_cmd { * @id: the device type identification (used to match it with a driver). * @config: the configuration ops for this device. * @vringh_config: configuration ops for host vrings. + * @map: configuration ops for device's mapping buffer * @vqs: the list of virtqueues for this device. * @features: the 64 lower features supported by both driver and device. * @features_array: the full features space supported by both driver and * device. * @priv: private pointer for the driver's use. + * @vmap: device virtual map * @debugfs_dir: debugfs directory entry. * @debugfs_filter_features: features to be filtered set by debugfs. */-- An old man doll... just what I always wanted! - Clara