[Public]

Hi,

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Wednesday, August 6, 2025 2:29 AM
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; Andrew Lunn
[off-list ref]; David S . Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo
Abeni [off-list ref]; netdev@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Greg Kroah-Hartman
[off-list ref]; Simek, Michal [off-list ref];
Leon Romanovsky [off-list ref]; Gupta, Suraj [off-list ref]
Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.

quoted

+static void axienet_disable_misc(void *clocks) {
+     clk_bulk_disable_unprepare(XAE_NUM_MISC_CLOCKS, clocks); }
+

...

quoted

      ret = devm_clk_bulk_get_optional(&pdev->dev, XAE_NUM_MISC_CLOCKS,

lp->misc_clks);

quoted

      if (ret)
-             goto cleanup_clk;
+             return dev_err_probe(&pdev->dev, ret,
+                                  "could not get misc. clocks\n");

      ret = clk_bulk_prepare_enable(XAE_NUM_MISC_CLOCKS, lp->misc_clks);
      if (ret)
-             goto cleanup_clk;
+             return dev_err_probe(&pdev->dev, ret,
+                                  "could not enable misc. clocks\n");
+
+     ret = devm_add_action_or_reset(&pdev->dev, axienet_disable_misc,
+                                    lp->misc_clks);

It seems like it would be better to add
devm_clk_bulk_get_optional_enable(). There is already an
devm_clk_bulk_get_all_enabled() so it does not seem like too big a step.

        Andrew

We are interested in this patch to fix AXI Ethernet probe path and can collaborate on upstreaming it.

Regards,
Suraj