Re: [PATCH net-next v4 6/7] net: axienet: Rearrange lifetime functions
From: Simon Horman <horms@kernel.org>
Date: 2025-08-05 20:39:16
Also in:
linux-arm-kernel, lkml
On Tue, Aug 05, 2025 at 11:34:55AM -0400, Sean Anderson wrote:
Rearrange the lifetime functions (probe, remove, etc.) in preparation for the next commit. No functional change intended. Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
...
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h
...
quoted hunk ↗ jump to hunk
/** * struct axienet_local - axienet private per device data * @ndev: Pointer for net_device to which it will be attached.@@ -549,6 +572,7 @@ struct skbuf_dma_descriptor { struct axienet_local { struct net_device *ndev; struct device *dev; + struct axienet_common *cp;
nit: Please add cp to, and remove axi_clk and regs_start from
the Kernel doc for this structure.
Flagged by ./scripts/kernel-doc -none
quoted hunk ↗ jump to hunk
struct phylink *phylink; struct phylink_config phylink_config;@@ -558,13 +582,11 @@ struct axienet_local { bool switch_x_sgmii; - struct clk *axi_clk; struct clk_bulk_data misc_clks[XAE_NUM_MISC_CLOCKS]; struct mii_bus *mii_bus; u8 mii_clk_div; - resource_size_t regs_start; void __iomem *regs; void __iomem *dma_regs;
...