Re: [PATCH RFC 1/4] net: stmmac: platform: read channels irq
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-12-14 22:31:17
Also in:
imx, linux-arm-kernel, linux-devicetree, lkml
On Sun, Dec 14, 2025 at 11:15:37PM +0100, Jan Petrous via B4 Relay wrote:
quoted hunk ↗ jump to hunk
From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> Read IRQ resources for all channels, to allow multi IRQ mode for platform glue drivers. Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> --- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 38 +++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 8979a50b5507..29e40253bdfe 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c@@ -700,6 +700,9 @@ EXPORT_SYMBOL_GPL(stmmac_pltfr_find_clk); int stmmac_get_platform_resources(struct platform_device *pdev, struct stmmac_resources *stmmac_res) { + int i; + char name[8];
Reverse Christmas tree please.
quoted hunk ↗ jump to hunk
memset(stmmac_res, 0, sizeof(*stmmac_res)); /* Get IRQ information early to have an ability to ask for deferred@@ -743,7 +746,40 @@ int stmmac_get_platform_resources(struct platform_device *pdev, stmmac_res->addr = devm_platform_ioremap_resource(pdev, 0); - return PTR_ERR_OR_ZERO(stmmac_res->addr); + if (IS_ERR(stmmac_res->addr)) + return PTR_ERR(stmmac_res->addr); + + /* RX channels irq */ + for (i = 0; i < MTL_MAX_RX_QUEUES; i++) { + scnprintf(name, 8, "rx-queue-%d", i);
It would be better to use sizeof(name), not 8. Also, 'rx-queue-' is 9 characters. So i don't see how this can actually work? Andrew