RE: [PATCH net-next v4 1/6] devlink: pass extack through to devlink_param::get()
From: Loktionov, Aleksandr <hidden>
Date: 2025-11-18 07:58:50
Also in:
linux-doc, linux-rdma
-----Original Message-----
From: Daniel Zahka <daniel.zahka@gmail.com>
Sent: Tuesday, November 18, 2025 1:24 AM
To: Jiri Pirko <jiri@resnulli.us>; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Jakub
Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Simon
Horman [off-list ref]; Jonathan Corbet [off-list ref]; Srujana
Challa [off-list ref]; Bharat Bhushan [off-list ref];
Herbert Xu [off-list ref]; Brett Creeley
[off-list ref]; Andrew Lunn [off-list ref]; Michael
Chan [off-list ref]; Pavan Chebbi
[off-list ref]; Nguyen, Anthony L
[off-list ref]; Kitszel, Przemyslaw
[off-list ref]; Goutham, Sunil Kovvuri
[off-list ref]; Linu Cherian [off-list ref]; Geetha
sowjanya [off-list ref]; Jerin Jacob [off-list ref];
hariprasad [off-list ref]; Subbaraya Sundeep
[off-list ref]; Tariq Toukan [off-list ref]; Saeed
Mahameed [off-list ref]; Leon Romanovsky [off-list ref]; Mark
Bloch [off-list ref]; Ido Schimmel [off-list ref]; Petr
Machata [off-list ref]; Manish Chopra [off-list ref];
Maxime Coquelin [off-list ref]; Alexandre Torgue
[off-list ref]; Siddharth Vadapalli <s-
vadapalli@ti.com>; Roger Quadros [off-list ref]; Loic Poulain
[off-list ref]; Sergey Ryazanov
[off-list ref]; Johannes Berg [off-list ref];
Vladimir Oltean [off-list ref]; Michal Swiatkowski
[off-list ref]; Loktionov, Aleksandr
[off-list ref]; Ertman, David M
[off-list ref]; Vlad Dumitrescu [off-list ref];
Russell King (Oracle) [off-list ref]; Alexander Sverdlin
[off-list ref]; Lorenzo Bianconi [off-list ref]
Cc: netdev@vger.kernel.org; linux-doc@vger.kernel.org; linux-
rdma@vger.kernel.org
Subject: [PATCH net-next v4 1/6] devlink: pass extack through to
devlink_param::get()
Allow devlink_param::get() handlers to report error messages via
extack. This function is called in a few different contexts, but not
all of them will have an valid extack to use.
When devlink_param::get() is called from param_get_doit or
param_get_dumpit contexts, pass the extack through so that drivers can
report errors when retrieving param values. devlink_param::get() is
called from the context of devlink_param_notify(), pass NULL in for
the extack.
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
---
Notes:
v3:
- fix warnings about undocumented param in intel ice driver...
-- 2.47.3
Reviewed-by: Aleksandr Loktionov <redacted>