-----Original Message-----
From: Daniel Zahka <daniel.zahka@gmail.com>
Sent: Tuesday, November 18, 2025 1:25 AM
To: Jiri Pirko <jiri@resnulli.us>; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Jakub
Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Simon
Horman [off-list ref]; Jonathan Corbet [off-list ref]; Srujana
Challa [off-list ref]; Bharat Bhushan [off-list ref];
Herbert Xu [off-list ref]; Brett Creeley
[off-list ref]; Andrew Lunn [off-list ref]; Michael
Chan [off-list ref]; Pavan Chebbi
[off-list ref]; Nguyen, Anthony L
[off-list ref]; Kitszel, Przemyslaw
[off-list ref]; Goutham, Sunil Kovvuri
[off-list ref]; Linu Cherian [off-list ref]; Geetha
sowjanya [off-list ref]; Jerin Jacob [off-list ref];
hariprasad [off-list ref]; Subbaraya Sundeep
[off-list ref]; Tariq Toukan [off-list ref]; Saeed
Mahameed [off-list ref]; Leon Romanovsky [off-list ref]; Mark
Bloch [off-list ref]; Ido Schimmel [off-list ref]; Petr
Machata [off-list ref]; Manish Chopra [off-list ref];
Maxime Coquelin [off-list ref]; Alexandre Torgue
[off-list ref]; Siddharth Vadapalli <s-
vadapalli@ti.com>; Roger Quadros [off-list ref]; Loic Poulain
[off-list ref]; Sergey Ryazanov
[off-list ref]; Johannes Berg [off-list ref];
Vladimir Oltean [off-list ref]; Michal Swiatkowski
[off-list ref]; Loktionov, Aleksandr
[off-list ref]; Ertman, David M
[off-list ref]; Vlad Dumitrescu [off-list ref];
Russell King (Oracle) [off-list ref]; Alexander Sverdlin
[off-list ref]; Lorenzo Bianconi [off-list ref]
Cc: netdev@vger.kernel.org; linux-doc@vger.kernel.org; linux-
rdma@vger.kernel.org
Subject: [PATCH net-next v4 5/6] netdevsim: register a new devlink
param with default value interface

Create a new devlink param, test2, that supports default param actions
via the devlink_param::get_default() and
devlink_param::reset_default() functions.

Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
---
 drivers/net/netdevsim/dev.c       | 55
+++++++++++++++++++++++++++++++
 drivers/net/netdevsim/netdevsim.h |  1 +
 2 files changed, 56 insertions(+)

...

+static int
+nsim_devlink_param_test2_get_default(struct devlink *devlink, u32 id,
+				     struct devlink_param_gset_ctx *ctx,
+				     struct netlink_ext_ack *extack) {
+	ctx->val.vu32 = 1234;
+	return 0;
+}
+
+static int
+nsim_devlink_param_test2_reset_default(struct devlink *devlink, u32
id,
+				       enum devlink_param_cmode cmode,
+				       struct netlink_ext_ack *extack) {
+	struct nsim_dev *nsim_dev = devlink_priv(devlink);
+
+	nsim_dev->test2 = 1234;
+	return 0;
+}
+

Duplicated magic value instead of the provided macro.
The default value 1234 is hard‑coded in two helpers even though NSIM_DEV_TEST2_DEFAULT is defined and already used for initialization.
Better use the same defined constant in both places.

Everything else looks good
Reviewed-by: Aleksandr Loktionov <redacted>

--
2.47.3