Re: [PATCH net-next v4 4/4] net: ftgmac100: Add RGMII delay support for AST2600

From
Tao Ren <hidden>
Date
2025-11-26 08:57:26
Also in
linux-arm-kernel, linux-aspeed, linux-devicetree, lkml
Reply to
Andrew Lunn, 2025-11-25
Hi Andrew,

On Wed, Nov 26, 2025 at 12:49:57AM +0100, Andrew Lunn wrote:
quoted
I try to summary in the following informations that I understand.

1. with rx-internal-delay-ps OR tx-internal-delay-ps OR both

  Use "rx/tx-internal-delay-ps" property to configure RGMII delay at MAC side
  Pass "phy-mode" to PHY driver by calling of_phy_get_and_connect()
Yes, since they are new properties, you can assume the phy-mode is
correct for these delays. We just need to watch out for DT developers
setting these delays to 2000ps and 'rgmii', which would be against the
guidelines.

quoted
2. withour rx-internal-delay-ps AND tx-internal-delay-ps

  If "phy-mode" is 'rgmii-rxid' or 'rgmii-txid':
	Keep original delay
	Print Warning message
	  "Update 'phy-mode' to rgmii-id and add 'rx/tx-internal-delay-ps'"

There are FOUR conditions in delay configuration:
'X' means RGMII delay setting from bootloader
A: 7500 <= X <= 8000, 0 <= X <= 500
B: 500 < X < 1500
C: 1500 <= X <= 2500
	Mean "Enable RGMII delay" at MAC side
D: 2500 < X < 7500

  If "phy-mode" is 'rgmii':
	Condition A:
		Keep original delay
		Update "phy-mode" to 'rgmii-id'
		Print Information message
			"Forced 'phy-mode' to rgmii-id"
So 0 <= X <= 500 is a small tuning value, so yes, is correct.
quoted
	Condition B and D
		Keep original delay
		Print Warning message
	  		"Update 'phy-mode' to rgmii-id and add 'rx/tx-internal-delay-ps'"
Yes.
quoted
	Condition C:
		Disable RGMII delay at MAC side
		Update "phy-mode" to 'rgmii-id'
		Print Warning message
	  		"Update 'phy-mode' to rgmii-id and add 'rx/tx-internal-delay-ps'"
'rx/tx-internal-delay-ps are probably not required in this case, the
2ns from the PHY is probably sufficient.
quoted
  If "phy-mode" is 'rgmii-id':
	Condition A:
		Keep original delay
		Keep "phy-mode" to 'rgmii-id'
	Condition B and D
		Keep original delay
		Print Warning message
	  		"Update 'phy-mode' to rgmii-id and add 'rx/tx-internal-delay-ps'"
	Condition C:
		Disable RGMII delay at MAC side
		Update "phy-mode" to 'rgmii-id'
		Print Warning message
	  		"Update 'phy-mode' to rgmii-id and add 'rx/tx-internal-delay-ps'"
These look correct.

How many different boards do you have you can test with? Do you only
have access to RDKs? Or do you have a test farm of customer boards for
regression testing. I would throw the patchset at as many boards as
you can to make sure there are no regressions.
I synced with Jacky offline a few times, and I'm happy to test the
patches on my Facebook Network OpenBMC platforms.

Hi Jacky,

Looking forward to your v5, and please don't hesitate to ping me offline
if you need more info about my test hardware.


Cheers,

Tao
Thread (22 messages) 22 messages, 4 authors, last reply 2025-12-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help