Re: [PATCH net-next v2 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller
From: Yao Zi <hidden>
Date: 2025-11-15 11:28:11
Also in:
lkml
On Tue, Nov 11, 2025 at 11:07:24AM +0000, Russell King (Oracle) wrote:
On Tue, Nov 11, 2025 at 10:52:51AM +0000, Yao Zi wrote:quoted
+ plat->bus_id = pci_dev_id(pdev); + plat->phy_addr = -1; + plat->phy_interface = PHY_INTERFACE_MODE_GMII; + plat->clk_csr = STMMAC_CSR_20_35M; + plat->tx_coe = 1; + plat->rx_coe = 1; + plat->maxmtu = JUMBO_LEN; + plat->rx_queues_to_use = 1; + plat->tx_queues_to_use = 1; + plat->clk_ref_rate = 125000000; + plat->core_type = DWMAC_CORE_GMAC4; + plat->suspend = stmmac_pci_plat_suspend; + plat->resume = motorcomm_resume; + plat->flags = STMMAC_FLAG_TSO_EN;Can you also set STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP here, so if EEE is used, we can shut down the transmit clock to the PHY if the PHY supports that? I would like all new glue drivers to set this where possible please.
Yes, the flag could be set and I'll do it in v3. Regards, Yao Zi
Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!