Re: [PATCH net-next 1/2] net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-11-14 14:32:50
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-11-14 14:32:50
Also in:
lkml
If I understand correctly, do you mean to store the capability details in the phydev structure when genphy_c45_oatc14_get_sqi_max() is called, and then use them in the genphy_c45_oatc14_get_sqi() function? In that case, I may need to introduce new parameters in the phydev structure. Do you think introducing new parameters in the phydev structure is still necessary for this?
I'm not sure it is worth it. Do we expect an SNMP agent polling the SQI value once per second? Once per minute? One extra read per minute costs nothing. If it was happening more frequently, then it might be worth caching the capabilities. How do you see this being used? Andrew