Hi Andrew,

Thank you for reviewing the patches.

On 13/11/25 7:09 pm, Andrew Lunn wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Thu, Nov 13, 2025 at 05:22:04PM +0530, Parthiban Veerasooran wrote:

quoted

This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+
support for OATC14 10Base-T1S PHYs, along with integration into the
Microchip T1S PHY driver. These changes enable higher-layer drivers and
diagnostic tools to assess link quality more accurately.

Higher-layer drivers? I don't know of any examples at the moment.  Are
you thinking of a new bond mode, where it will do active-backup based
on the best SQI values?

I think I misstated it here. I meant that the higher-layer drivers are 
the OATC14 10Base-T1S PHY drivers, which can use the generic APIs 
implemented in PHYLIB to obtain SQI value. Currently, this patch series 
is intended only for ethtool.

I should have described the patch series more specifically as follows:

This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+ 
support for OATC14 10Base-T1S PHYs, along with integration into the 
Microchip T1S PHY driver. This enables ethtool to report the SQI value 
for OATC14 10Base-T1S PHYs.

If this explanation clarifies things, I will update it in the next version.

Best regards,
Parthiban V

         Andrew