Re: [PATCH v5 3/8] net: stmmac: qcom-ethqos: improve typing in devres callback
From: Bartosz Golaszewski <hidden>
Date: 2025-11-13 13:31:35
Also in:
imx, linux-amlogic, linux-arm-msm, linux-devicetree, linux-mips, linux-renesas-soc, linux-riscv, linux-rockchip, linux-sunxi, lkml
On Fri, Nov 7, 2025 at 11:50 AM Konrad Dybcio [off-list ref] wrote:
On 11/7/25 11:29 AM, Bartosz Golaszewski wrote:quoted
From: Bartosz Golaszewski <redacted> It's bad practice to just directly pass void pointers to functions which expect concrete types. Make it more clear what type ethqos_clks_config() expects. Signed-off-by: Bartosz Golaszewski <redacted> --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 8578a2df8cf0d1d8808bcf7e7b57c93eb14c87db..8493131ca32f5c6ca7e1654da0bbf4ffa1eefa4e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c@@ -726,7 +726,9 @@ static int ethqos_clks_config(void *priv, bool enabled) static void ethqos_clks_disable(void *data) { - ethqos_clks_config(data, false); + struct qcom_ethqos *ethqos = data; + + ethqos_clks_config(ethqos, false);ethqos_clks_config() takes a voidptr too Konrad
Right. I think I had something in mind when I wrote it but I'm not sure what anymore. Best drop this. Bart